search

pimentel / atom-r-exec

Send R code to various R consoles from the Atom editor
https://atom.io/packages/r-exec
MIT License
19 stars 8 forks source link

Override default keybinding for cmd-enter #53

Open kylebarron opened 6 years ago

kylebarron commented 6 years ago

I thought it was weird that you'd need to manually add something to your keymap.cson to use cmd-enter, because I use the Hydrogen package often and I never had to edit the keymap to use cmd-enter with that package.

Looking at Hydrogen's keymap.cson, the included changes should force the use of cmd-enter for this package. I've also added [data-grammar="source r"] because it's likely anyone using this package would only be using it for files covered by the R grammar file, but you could take that out if you want.

I believe this could fix https://github.com/pimentel/atom-r-exec/issues/52 and https://github.com/pimentel/atom-r-exec/issues/51.

pimentel commented 6 years ago

fantastic. thanks, @kylebarron! going to test this out and merge later this week.

kylebarron commented 6 years ago

Also, thanks for the awesome package! It was really easy to port all the functionality to running code in Stata.