search

pimeys / rust-web-push

A Web Push library for Rust
Apache License 2.0
113 stars 21 forks source link

Push v0.7.3 to crates.io #29

Closed andyblarblar closed 3 years ago

andyblarblar commented 3 years ago

Hello, I'm aware this repo is more or less unmaintained, but I figured this would be simpler than dealing with a fork. At the moment #22, which updated to tokio v1, is not available on any published version of this repo. Since it looks like master is stable, it would be very helpful if you could push this version (even as a beta perhaps) to crates.io such that we can use it as a dependency. Without this version bump, this crate cannot run on the latest versions of most web frameworks due to tokio versioning. Thanks.

megrogan commented 3 years ago

In the meantime could use a git reference in your cargo.toml:

web-push = { git = "ssh://github.com/pimeys/rust-web-push", ref = "85870ec55badfb95d74d1c7bd354a0deb5193481" }

andyblarblar commented 3 years ago

In the meantime could use a git reference in your cargo.toml:

web-push = { git = "ssh://github.com/pimeys/rust-web-push", ref = "85870ec55badfb95d74d1c7bd354a0deb5193481" }

This is what I've been doing, and it does work in development. It is worth pointing out however that you cannot upload crates with a git dependency, so this isn't really a fix.

andyblarblar commented 3 years ago

Closing as v0.8 was published in 4cac72a2ca2e6c8414f9ac49fcf41609ab35ac28 😁

pimeys commented 3 years ago

If somebody wants to take admin here, you're all welcome!

andyblarblar commented 3 years ago

If somebody wants to take admin here, you're all welcome!

I'd be happy to take up a maintainer role, if that's what you mean. I don't currently have any real repositories to look out for, so it would be nice to pick this up - particularly now that I know the codebase well.