search

pimeys / rust-web-push

A Web Push library for Rust
Apache License 2.0
114 stars 21 forks source link

WebPushMessageBuilder::new needlessly returns result #47

Closed ranile closed 1 year ago

ranile commented 1 year ago

https://github.com/pimeys/rust-web-push/blob/c5a8e1250b3fc85c5005dcb321e01ba4253b584d/src/message.rs#L113-L121

This function is infallible and thus should not return a result.

andyblarblar commented 1 year ago

nice catch. We should change this and push the breaking change on the next semver bump