web-push fails if notification is to be sent to Firefox

pimeys / rust-web-push

A Web Push library for Rust

Apache License 2.0

114 stars 21 forks source link

web-push fails if notification is to be sent to Firefox #48

Closed ranile closed 1 year ago

ranile commented 1 year ago

The library does not set Authorization header on the outgoing request to the push service endpoint. Mozilla's service fails with if this is not provided.

See more:

Autopush HTTP documentation
Application Server Self-Identification in the VAPID RFC
Common issues with firefox when sending notifications

andyblarblar commented 1 year ago

Firefox has worked fine with my tests of this library since a fix a few versions ago (Fixing this issue https://github.com/mozilla-services/autopush-rs/issues/361). Make sure you're using the most recent version of this crate, or provide a minimal example of the issue otherwise.

ranile commented 1 year ago

It was an issue on my end where dependency conflicts meant I didn't get the latest versions. Works fine on latest update. Thanks for the help!