pimlie / authres_status

Roundcube plugin that checks the Authentication-Results headers (rfc5451) of your emails and displays the verification status.
Other
36 stars 20 forks source link

Unable to toggle "Only show the following statuses" #35

Closed alfredo-ardito closed 4 years ago

alfredo-ardito commented 4 years ago

in settings none of the options in the "Only show the following statuses" section can be set. When I try to toggle one of the above options, it sets the "Enable authentication result column in message list" instead. Screenshot_2019-11-15_22-48-27

photoninger commented 4 years ago

Here is a fix for this issue:

--- authres_status.php.orig 2020-01-15 17:34:54.089039813 +0100
+++ authres_status.php  2020-01-15 17:34:26.708973143 +0100
@@ -141,7 +141,7 @@
                     $args['blocks']['authresstatus']['name'] = $this->gettext('title_include_status');

                     $args['blocks']['authresstatus']['options']['enable' . $status]['title'] = $this->gettext('label_include_status' . $status);
-                    $input = new html_checkbox(array('name' => '_show_statuses[]', 'id' => 'enable_authres_status_column', 'value' => $status));
+                    $input = new html_checkbox(array('name' => '_show_statuses[]', 'id' => 'enable_authres_status_' . $status, 'value' => $status));
                     $args['blocks']['authresstatus']['options']['enable' . $status]['content'] = $input->show(($show_statuses & $status));
                 }
             }

I don't understand why it is only broken in elastic, but who cares...

pimlie commented 4 years ago

Resolved by linked PR