pimlie / authres_status

Roundcube plugin that checks the Authentication-Results headers (rfc5451) of your emails and displays the verification status.
Other
34 stars 20 forks source link

Undefined array key "fetch_headers" (PHP8 related) #50

Closed smirkybg closed 2 years ago

smirkybg commented 3 years ago

Hello,

Since PHP8, these warnings appear in the logs: [13-Mar-2021 14:51:41 Europe/Sofia] PHP Warning: Undefined array key "fetch_headers" in /usr/share/webapps/roundcubemail/plugins/authres_status/authres_status.php on line 101

[13-Mar-2021 15:08:44 Europe/Sofia] PHP Warning: Undefined array key "x-dkim-authentication-results" in /usr/share/webapps/roundcubemail/plugins/authres_status/authres_status.php on line 336

Roundcube is catching up already with PHP8 with its first 1.5-Beta and is close to an official release. It will be great if this plugin is also ready prior to the release too for a smooth transition.

https://github.com/pimlie/authres_status/blob/ef071d483356c18ec957290ddfc62aaef565700d/authres_status.php#L101 https://github.com/pimlie/authres_status/blob/ef071d483356c18ec957290ddfc62aaef565700d/authres_status.php#L336

smirkybg commented 1 year ago

@pimlie @GermanCoding Guys, can you please do a release? It's been 2 years and all of the commits in the master branch would be very appreciated.

GermanCoding commented 1 year ago

Not my call, I'm just a contributor.

However, what I have been doing all this time is to just pull the latest master version from this repo. You can do so like this:

composer require pimlie/authres_status:dev-master

I agree with you that this is not an ideal solution and a release would be better, as it won't contain unexpected future changes.