search

pimonteiro / CG

MIT License
0 stars 0 forks source link

Pm/camtull #43

Closed pimonteiro closed 5 years ago

pimonteiro commented 5 years ago

All works except the translation doesn't respect the time defined to complete it. Will fix in the next PR.

BrunoMartins11 commented 5 years ago

It depends if it always exists or not. If we are not sure you should check it.

herulume commented 5 years ago

It depends if it always exists or not. If we are not sure you should check it.

My problem is exactly this.

If this matrix module doesn't need checks because it's only used by the Catmull, and the Catmull guarantees (by some math property or algorithm) that those bounds always exist it's fine. I would prefer if the matrix's module function would be in the Catmull file though since they are local.

If that module is to be used in other parts of the project we really should check the bounds.

pimonteiro commented 5 years ago

It depends if it always exists or not. If we are not sure you should check it.

My problem is exactly this.

If this matrix module doesn't need checks because it's only used by the Catmull, and the Catmull guarantees (by some math property or algorithm) that those bounds always exist it's fine. I would prefer if the matrix's module function would be in the Catmull file though since they are local.

If that module is to be used in other parts of the project we really should check the bounds.

They will also be used in another file so it should seperated from Catmull. Also, there's no need for checking as it's only supposed to be used knowing the sizes of the matrix used (fixed 4). This code was given by the teacher so i think we shouldn't stress about small things that won't happen.

herulume commented 5 years ago

It depends if it always exists or not. If we are not sure you should check it.

My problem is exactly this. If this matrix module doesn't need checks because it's only used by the Catmull, and the Catmull guarantees (by some math property or algorithm) that those bounds always exist it's fine. I would prefer if the matrix's module function would be in the Catmull file though since they are local. If that module is to be used in other parts of the project we really should check the bounds.

They will also be used in another file so it should seperated from Catmull. Also, there's no need for checking as it's only supposed to be used knowing the sizes of the matrix used (fixed 4). This code was given by the teacher so i think we shouldn't stress about small things that won't happen.

They are not small things. If we have the guarantee that the bounds always exist I'm fine with that. Fix the missing stuff and it should be good to go.