Decode CPU temperature for Python 3 support

pimoroni / bme280-python

Python library for the BME280 temperature, pressure and humidity sensor

https://shop.pimoroni.com/products/bme280-breakout

MIT License

65 stars 25 forks source link

Decode CPU temperature for Python 3 support #18

Closed LionsPhil closed 2 years ago

LionsPhil commented 3 years ago

This ports the changes from https://github.com/pimoroni/enviroplus-python/pull/23 , where this same function is copied.

LionsPhil commented 3 years ago

Looks like the test failure is that Python 3.4 is missing in that environment? Not sure why the rest were cancelled, unless a maintainer did it.

I've manually checked this with 3.7.3, although I haven't done any regressions for 2.x, largely because this is copying an existing fix from another Pimoroni repo with BME280 code.

Gadgetoid commented 2 years ago

Tests auto-cancel when something explodes, looks like I've fixed them in the interim. If you have the time/inclination then a rebased PR would be welcome. Thank you.

LionsPhil commented 2 years ago

Been a while since I've done GitHub flow, but believe that's got you a clean rebase onto current head.

Gadgetoid commented 2 years ago

That seems to have done the trick, thank you!

coveralls commented 2 years ago

Coverage remained the same at 96.429% when pulling 3624f33b0c24ed5de9c2131484c5e91193a94a2e on LionsPhil:patch-1 into 444d3b1ae907d812baf71e42c2490ca12f40e0cb on pimoroni:master.