pimoroni / enviro

MIT License
101 stars 79 forks source link

Add support for MQTT pver SSL and update to attemp disconnects and extra loggin on mqtt failures #125

Closed dave-ct closed 1 year ago

dave-ct commented 1 year ago

Add support for a local mqtt broke that uses ssl. Allow user to add in their ca,crt file and if exists use SSL for mqtt uploads.

Relates to issue #122

ZodiusInfuser commented 1 year ago

Thanks for this. A few additions:

dave-ct commented 1 year ago

Added a couple more updates here, still testing to see if they work.

ZodiusInfuser commented 1 year ago

Thank you for the additions. Any chance you can raise the logging change as a separate PR to this please? Makes it easier on my end to evaluate and approve the changes.

dave-ct commented 1 year ago

@ZodiusInfuser have reverted from here and created new pull request https://github.com/pimoroni/enviro/pull/128

Will also clean this pull request so it just relates to mqtt

ZodiusInfuser commented 1 year ago

Thanks for tidying this up. There's a few things from a code standpoint that I'd like to do, but they can be done after this is merged in 🙂

ZodiusInfuser commented 1 year ago

Specifically, turn that exception logging line into a neater function call, and correct a few typos in the comments