search

pimoroni / enviro

MIT License
101 stars 79 forks source link

Would like to have rain per hour and rain today values #168

Open sjefferson99 opened 1 year ago

sjefferson99 commented 1 year ago

Weather underground only takes per hour and per day values for rain and these are useful values in their own right.

ZodiusInfuser commented 1 year ago

Hi @sjefferson99. These sound pretty easy to add, if all that's needed is scaling up the current measurement (so the rain per hour becomes an estimate). Recording the cumulative rain over a full hour our day would be a bit more complicated though.

Edit: I see your PR now

sjefferson99 commented 1 year ago

@ZodiusInfuser Apologies, I wasn't sure of the contribution approach so I created an issue for any PRs that didn't already have one to denote the reasoning behind them and tagged the issue in the PR. I'll make a clearer comment next time.