pimoroni / flotilla-python

Python library for the Pimoroni Flotilla plug-and-play electronics ecosystem
MIT License
25 stars 15 forks source link

Number and Matrix don't have a stop method #32

Closed veryalien closed 6 years ago

veryalien commented 6 years ago

When dock.stop is called it calls stop for all modules. I think the idea was to tidy up all the modules on exit, wasn't it? Motors stop and Rainbows stop (are cleared), but Number and Matrix modules don't stop, they only have clear functions, which are not called on exit. You need to add a stop alias for clear which would then clear the Number and Matrix on exit. And also fix the clearing of Number apostrophe and colon too (see issue #27)

veryalien commented 6 years ago

A stop alias for clear wouldn't be enough. A stop would need clear followed by an update. Which I forget every single time I try to "update" a value on a matrix, motor, number or rainbow and wonder why it doesn't react!