search

pimoroni / fourletter-phat

Python library for the Pimoroni Four Letter pHAT
https://shop.pimoroni.com/products/four-letter-phat
MIT License
29 stars 13 forks source link

minus sign not cleared when writing 3 digit values #8

Closed KenT2 closed 6 years ago

KenT2 commented 6 years ago

Using write_number_str and writing -3.25 (or any other -ve number) followed by 3.26 (or any other +ve number) the minus sign is not cleared.

Workaround is to clear the display before a write.

Gadgetoid commented 6 years ago

I've come across this before, and am wary to change the interface, but I think in all cases write_number_str should either clear the display or fill in unused characters with blanks to avoid this.

Gadgetoid commented 6 years ago

Yep, looks like this has already been ported over from Rainbow HAT I believe, and fixed in this commit: https://github.com/pimoroni/fourletter-phat/commit/af726cd6fae2a12d9ad394817289d559af18f132

It just hasn't found its way to a release yet.

Gadgetoid commented 6 years ago

Should be fixed in: https://github.com/pimoroni/fourletter-phat/releases/tag/v0.1.0