search

pimoroni / inky

Combined library for V2/V3 Inky pHAT and Inky wHAT.
https://shop.pimoroni.com/?q=inky
MIT License
590 stars 122 forks source link

Move fonts to example-depends #129

Closed missionfloyd closed 2 years ago

missionfloyd commented 2 years ago

They're only needed for the example scripts, and it doesn't make much sense to install them without the rest of their dependencies.

Gadgetoid commented 2 years ago

Thank you!

I'm broadly in favour of doing this, but need to make sure we still cater to the lowest common denominator. I think just updating install.sh to make sure example-depends are installed would work:

https://github.com/pimoroni/inky/blob/fc17026df35447c1147e9bfa38988e89e75c80e6/install.sh#L12-L18

Gadgetoid commented 2 years ago

Ugh, GitHub has utterly failed to pick up that I've made that change and merged this!

Merged as https://github.com/pimoroni/inky/commit/dc6925f89ad1e4ea02fe3ccde411cd5089067323

Thank you!