search

pimoroni / phat-beat

Python library for PHAT BEAT - A stereo DAC, AMP and VU for the Raspberry Pi
https://shop.pimoroni.com/products/phat-beat
MIT License
99 stars 28 forks source link

Fix vlcradio setup.sh to support raspbian buster #26

Closed mstahel closed 4 years ago

mstahel commented 4 years ago
mstahel commented 4 years ago

Fixes #25

Gadgetoid commented 4 years ago

Super appreciated- thank you!

Gadgetoid commented 4 years ago

That's odd- the vlcradio script should clone this repository at master, and the change is definitely there:

https://github.com/pimoroni/phat-beat/blob/cd860143e5d84e78e1ef81589d8f461ce34a4ea3/projects/vlc-radio/setup.sh#L203-L204

Where's your paste of setup.sh coming from?

Edit: Just ran curl https://get.pimoroni.com/vlcradio | bash on Buster here and it installed fine.

bobrathbone commented 4 years ago

Hi Philip,

curl https://get.pimoroni.com/vlcradio | bash

The above instruction comes from page 87 of my Internet radio project at https://bobrathbone.com/raspberrypi/documents/Raspberry%20PI%20Radio.pdf and is still available from get.pimoroni.com.

This instruction previously came from Pimoroni documentation, probably on GitHub.

Upon further investigation I now see that this has changed to:

curl https://get.pimoroni.com/phatbeat | bash

from instructions https://github.com/pimoroni/phat-beat#full-install-recommended

I have now retested using the new script and the installation now works fine.

I will update my documentation and issue #26 shortly

My apologies for any inconvenience.

Regards

Bob

Bob Rathbone

Website: http://www.bobrathbone.com

Email: bob@bobrathbone.com

lpic2-logo-small

From: Philip Howard [mailto:notifications@github.com] Sent: 11 March 2020 09:26 To: pimoroni/phat-beat Cc: Bob Rathbone; Comment Subject: Re: [pimoroni/phat-beat] Fix vlcradio setup.sh to support raspbian buster (#26)

That's odd- the vlcradio script should clone this repository at master, and the change is definitely there:

https://github.com/pimoroni/phat-beat/blob/cd860143e5d84e78e1ef81589d8f461ce34a4ea3/projects/vlc-radio/setup.sh#L203-L204

Where's your paste of setup.sh coming from?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/pimoroni/phat-beat/pull/26?email_source=notifications&email_token=ABTYIBWRMLKUXYOKA4MLLOLRG5KLXA5CNFSM4IYNAGNKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEOOY5HY#issuecomment-597528223 , or unsubscribe https://github.com/notifications/unsubscribe-auth/ABTYIBT4ZXBGU5UKYEYTWKDRG5KLXANCNFSM4IYNAGNA . https://github.com/notifications/beacon/ABTYIBTND23NPMGHMQFWVTLRG5KLXA5CNFSM4IYNAGNKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEOOY5HY.gif

-- This email has been checked for viruses by AVG. https://www.avg.com

bobrathbone commented 4 years ago

So which script should I be using? curl https://get.pimoroni.com/vlcradio | bash or curl https://get.pimoroni.com/phatbeat | bash

Gadgetoid commented 4 years ago

It depends what you want to accomplish-

vlcradio installs a whole plethora of software and configuration designed to get your Pi up and running as a radio using pHAT BEAT and the VLC music player.

phat-beat - if I recall correctly - just installs the python library and adds dtoverlay=hifiberry-dac to your /boot/config.txt - ie: gets the product up and running for you to write your own code.