Improve Python 3 compatibility

pimoroni / phat-beat

Python library for PHAT BEAT - A stereo DAC, AMP and VU for the Raspberry Pi

https://shop.pimoroni.com/products/phat-beat

MIT License

99 stars 28 forks source link

Improve Python 3 compatibility #37

Closed g6ai closed 2 years ago

g6ai commented 2 years ago

The proposed one-liner to install VLC Radio:

curl https://get.pimoroni.com/vlcradio | bash

seems to install Python 3 packages. However, the phatbeatd is still in Python 2, with which the daemon does not work on boot or manual excecution.

I believe this could be the cause of some problems posted in various platforms, which state the buttons are not working. After applying this fix, the buttons are working fine. I have confirmed on both Stretch and Buster btw :)

Gadgetoid commented 2 years ago

Thank you- I suspect we might have to pull in Python3 as a dependency somewhere, too, since I don't think it's installed by default on all platforms.

g6ai commented 2 years ago

Thanks for the fast confirmation!

Gadgetoid commented 2 years ago

Thanks for the PR- a few of our older product libraries have some bitrot and it's hard to find the time (and head space!) to get around to updating them. Much appreciated!