search

pimoroni / phew

MIT License
204 stars 44 forks source link

Close file handlers in logging.py #54

Open sorgo opened 1 year ago

sorgo commented 1 year ago

Close file handlers in logging.py to prevent hanging due to the leak

ccrighton commented 5 months ago

@sorgo @Gadgetoid I've reviewed this patch. It is not needed. The semantics of "with open" automatically closes the file. All of the calls to close in the patch are within "with" blocks.

@sorgo It would be interesting to have more details about the hangs you are experiencing. They are not caused by files being left open.