search

pimoroni / picovision

MIT License
46 stars 15 forks source link

Bug Fix in Seafax example: Changed BBC feed URLs to https to avoid error following redirects. #95

Closed simonprickett closed 11 months ago

simonprickett commented 11 months ago

The BBC feed URLs were all http, but these redirect to https versions of the same URL. The code wasn't following the redirect and would fail like this:

>>> %Run -c $EDITOR_CONTENT

MPY: soft reboot
Start I2C
Started
connecting...
Traceback (most recent call last):
  File "<stdin>", line 196, in <module>
  File "<stdin>", line 165, in update
  File "<stdin>", line 153, in get_rss
  File "urllib/urequest.py", line 62, in urlopen
NotImplementedError: Redirects not yet supported

Changing the URLs to https fixes this:

>>> %Run -c $EDITOR_CONTENT

MPY: soft reboot
Start I2C
Started
connecting...

(expected output appears on the HDMI display).

helgibbons commented 11 months ago

Thanks muchly Simon :)