Swap play and pause button states?

wooduk commented 4 years ago

I've been using pirate-audio 3W amp and I thought the play and pause icons are the wrong way around?

currently: I see the play icon displayed next to the physical button when the music is playing and the pause icon next to the physical button when the music is paused.
suggested by change: Is it more normal that the icon would show what would happen if the button was pressed? i.e. play icon would appear next to the button when the music was paused and pause icon would appear next to the button when the music was playing.

This change swaps the icons around.

Gadgetoid commented 4 years ago

I'm glad I'm not the only one who thinks this. @sandyjmacdonald what do you reckon?

sandyjmacdonald commented 4 years ago

@Gadgetoid I was of the same opinion, tbh! It was Jon who said it should show the current state, despite my protestations... 😁 Looking at both the Spotify and Apple Music apps on my phone, they do the opposite of what we currently do, so I'd definitely be up for changing it.

Gadgetoid commented 4 years ago

He'll never notice.

Never!

Muwahahahahaha!

Gadgetoid commented 2 years ago

Merged. This will confuse people!

Thank you all.

pimoroni / pidi-plugins

Swap play and pause button states? #2