Full repo build doesn't work on rp2350

pimoroni / pimoroni-pico

Libraries and examples to support Pimoroni Pico add-ons in C++ and MicroPython.

https://shop.pimoroni.com/collections/pico

MIT License

1.29k stars 492 forks source link

Full repo build doesn't work on rp2350 #1007

Open peardox opened 22 hours ago

peardox commented 22 hours ago

The removal of the RTC in Pico2 is causing some demos to fail on these devices

Attempting a full repo build with Ninja cases this error in breakout_encoder_wheel

/home/simon/pimoroni-pico/examples/breakout_encoder_wheel/clock/clock.cpp:6:10: fatal error: hardware/rtc.h: No such file or directory 6 | #include "hardware/rtc.h" | ^~~~ compilation terminated. [778/15238] Building CXX object examples/breakoutencoder...se_game.dir///__/drivers/ioexpander/ioexpander.cpp.obj ninja: build stopped: subcommand failed.

Gadgetoid commented 22 hours ago

There’s a fix for this - and other issues with SDK 2.0.0 - in one of the open PRs here- just requires an include change. I’ve been quite focussed in on the MicroPython stuff so it hasn’t made its way into main yet.

AIUI there’s another SDK revision coming this month… maybe… possibly… so I’m not in a tremendous hurry 😬

peardox commented 22 hours ago

OK, the Ninja build broke when I was testing my PR for pico_display_28 + SPI so I just built mine with Make to test and wanted to point it out in case it was unreported

Gadgetoid commented 7 hours ago

Collating those fixes here - https://github.com/pimoroni/pimoroni-pico/pull/1008