search

pimoroni / pimoroni-pico

Libraries and examples to support Pimoroni Pico add-ons in C++ and MicroPython.
https://shop.pimoroni.com/collections/pico
MIT License
1.28k stars 490 forks source link

Inky frame rotate #990

Open mrglennjones opened 1 month ago

mrglennjones commented 1 month ago

When using rotate=90 on the inky frame 7.3, it actually rotates it 180

Gadgetoid commented 1 month ago

🤔 https://github.com/pimoroni/pimoroni-pico/blob/970046e84ae73cad23deae28fd6e96427aa0eb64/drivers/inky73/inky73.cpp#L88

Looks like it doesn’t support 90/270 degree rotations (some mix of the chip not supporting it and/or it being a pain to accomplish in software) so if the rotation != 0 then it’s set to 180.

Might be worth looking into why 90 isn’t supported- of course past me didn’t leave any useful comment 😫