search

pimoroni / pxt-inkybit

pxt-microbit package for the Pimoroni inky:bit - a three-colour e-ink display for your micro:bit.
MIT License
6 stars 8 forks source link

Replace references in main.ts to Scroll:Bit with Inky:Bit #5

Closed dsssssssss9 closed 3 years ago

dsssssssss9 commented 3 years ago

Replace references in main.ts to Scroll:Bit with Inky:Bit as currently the following blocks & Java Mention Scroll:Bit....

Draw Text

Draw text

Get Pixel Size

Set Pixel Size

Pixel Size

Gadgetoid commented 3 years ago

Thank you. "Inky" should be lowercase "inky" in all cases.

Also the blockid change from scrollbit_cols to blockId=Inkybit_cols might break compatibility between this library and existing projects. That said, I don't know how updates to existing projects are handled. I don't think this is displayed to the user, though? So it might be worth leaving as blockId=scrollbit_cols to avoid any potential problems.

dsssssssss9 commented 3 years ago

Hi Shall I make the spelling change - sorry I've always been far to prone to capitalising names & nouns.

No problems if you feel it's best to leave things as they are - not the most earth shattering problem & I'm sure you've already got your time more than filled with more urgent stuff !

Feel free to close the request or would you prefer me to do it from here?

dsssssssss9 commented 3 years ago

With Thanks to you for the advice

Have closed PR - can always reopen it at a future date if needed