pimoroni / rgbmatrix5x5-python

Python library for the Pimoroni 5x5 RGB Matrix Breakout
https://shop.pimoroni.com/products/5x5-rgb-matrix-breakout
MIT License
12 stars 5 forks source link

is31fl3731: Fix nextframe index #19

Closed rzr closed 3 years ago

rzr commented 3 years ago

It looks like this what original author wanted, if not then next_frame should be set to 0 unconditionally

Forwarded: https://github.com/pimoroni/rgbmatrix5x5-python/pulls Signed-off-by: Philippe Coval philippe.coval@huawei.com

coveralls commented 3 years ago

Pull Request Test Coverage Report for Build 1390397522


Totals Coverage Status
Change from base Build 1278009048: 0.0%
Covered Lines: 154
Relevant Lines: 193

💛 - Coveralls
Gadgetoid commented 3 years ago

Wow. Good spot. And you're correct! Thank you.

rzr commented 3 years ago

thx, for the story I have been translating this driver to native C fo oniro project,

I will share it to community as standalone library, watch:

https://mastodon.social/@rzr/107105016701665015