search

pimoroni / speaker-phat

Software installer for Speaker pHAT
MIT License
52 stars 9 forks source link

One-line installer bug #10

Closed simonbugler closed 7 years ago

simonbugler commented 7 years ago

The one-line installer has a bug. Whether you answer y or n it aborts.

However after a few attempts answering y or n it does kick in.

This has happened on 3 installs on 3 different pi's - haven't figured out the right combination.

RogueM commented 7 years ago

it sounds like there is some spurious entry being passed on, maybe a key repeat that makes it read 'yyyy' or something like that? do you ssh into the box or maybe use a bluetooth keyboard?

simonbugler commented 7 years ago

yes - these are all by ssh

RogueM commented 7 years ago

yes, it has happened to me before, particularly with Pi zeros... it's not really a bug in the installer per se, though I guess it could treat any input starting with 'y' as validation, rather than a literal parsing.

simonbugler commented 7 years ago

Maybe - not had the same issue with other Pimoroni one line installers

RogueM commented 7 years ago

I'll look into improving the handling of the user input for 'stuck keys' but it's definitely not a (new) 'bug', nor specific to the speakerphat installer, all our installers derive from the same template.

I have created myself an issue in the main 'get' installer repo so I don't forget about this: https://github.com/pimoroni/get/issues/188