Closed jacobbramley closed 3 years ago
Thank you- I'll review this as soon as I can. Your thoroughness with respect to licensing considerations is greatly appreciated. As, of course, are your contributions!
In lieu of the time to give this a thorough review I have merged so at least it's readily available for others to use (and raise an issue if something goes awry). Thank you!
Hello,
I've got a few patches that fix the C library and example client. The changes are independent, so I can split them into separate pull requests if you like. (I'm not sure of the etiquette here.) The actual changes are described in the commit messages.
As I understand #136, files under
library_c/unicornd/
are currently licensed as GPLv2. There is a pull request (#137) changing the licence ofunicornd
to MIT, but it's not merged to master yet. My contributions tounicornd
are therefore under the GPLv2 licence, but under the assumption that #137 will merge at some point, you have my permission to relicense these contributions as MIT. My intention is to decouple my pull request from #137.My contributions to
library_c/unicorn/
are licensed as MIT (as per the top-levelLICENSE
file) and are not affected by #137.Thanks! Jacob