search

pimoroni / weatherhat-python

MIT License
24 stars 16 forks source link

history.py <> ms_to_mph #17

Closed IanD42 closed 4 months ago

IanD42 commented 2 years ago

Not sure but I think there is a typo in:- image Should cms be ms

cbeierlbuffs commented 1 year ago

I agree IanD42. The "c" in "cms" should be removed

bsimmo commented 1 year ago

Bump, came across this error today as well.

There has been a pull for this for while it seems https://github.com/pimoroni/weatherhat-python/pull/18

Could you merge the pull, I know you're all RP2040 boards now, but don't forget about us old fashioned HAT users ;-)

Gadgetoid commented 1 year ago

Merged! I need to tag a release and... release the code... though, which is rather more of an adventure since a lot of our stuff has bitrot rather horribly :cry: which you can see by the merged code exploding our CI/tests.

Hey I have a Weather HAT running 24/7 up on my office wall!

bsimmo commented 1 year ago

I know, I think you post updates on twitter about it?

I was just adding in my HomeAssistant autodetect mqtt stuff, or trying as learning as I do it, and thought I'd add history and send as mph, well it didn't like that. 😆

You have too many products to look after now at Pimoroni :-). Let's see what Bookworm PiOS when released along with the newer Python3 does to all of this...

Gadgetoid commented 1 year ago

Just trying to unpick the packaging mayhem now! Good grief a lot changed in very little time and it's a monster of an update.

Yes I've been shouting about the weather HAT and graphs- just moved my datastore onto a "real" PC so I can throw all sorts of things at it with impunity.

Bookworm is going to rain on my parade. My nuclear option is to add the following to ~/bashrc automatically and pretend the whole venv problem doesn't exist-

PY_ENV_DIR=~/.python_venv
if [ ! -f $PY_ENV_DIR/bin/activate ]; then
  printf "Creating user Python environment, please wait...\n"
  python3 -m venv --system-site-packages $PY_ENV_DIR
fi
export VIRTUAL_ENV_DISABLE_PROMPT=1
source $PY_ENV_DIR/bin/activate
Gadgetoid commented 1 year ago

Okay, I published version 0.0.2 yesterday evening. Hopefully it rounds up and fixes some of the bugs that have been floating here for a while.

helgibbons commented 4 months ago

Think the issues here should now be resolved - if not, please let us know!

@bsimmo The new release should work with Bookworm/Pi 5, if that's been something you've been waiting for :)