search

pimoroni / weatherhat-python

MIT License
24 stars 16 forks source link

Add dependencies and I2C/SPI to installer #2

Closed helgibbons closed 2 years ago

helgibbons commented 2 years ago

An attempt was made!

Gadgetoid commented 2 years ago

I should - uh - probably remove defunct versions of Python from the CI!

Actually versions listed are here, if you want to try removing them from your commit - https://github.com/pimoroni/weatherhat-python/blob/dbe65cdafc4d741c647965d17f2b864449bd7ebd/.github/workflows/test.yml#L14

I don't think requiring 3.6 is a bad thing. Python 2.x was supposed to be dead and buried in 2012 :laughing:

Gadgetoid commented 2 years ago

Oh the tests are also failing because there are no tests - https://github.com/pimoroni/weatherhat-python/blob/dev/library/tests/test_setup.py

I... usually have no idea what the surface area of a library is going to look like, and write these last to avoid regressions.

In the short term, it's fine to just ignore the shouty CI errors.

helgibbons commented 2 years ago

Cool, I've left it as (arbitrarily) python_requires = >= 3.5 for now :D