350: Safely Opening

[MrHug]

We discussed this earlier, I think we should have it.

0.1 points for

"We keep moving forward, opening new doors, and doing new things, because we're curious and curiosity keeps leading us down new paths." (Walt Disney)

[pimotte]

This would probably move all of the weight onto merging. I'm not necessarily against that, but it should be a factor in consideration.

[jdonkervliet]

As said in verbal discussion: this would allow a player to open a PR while their turn is frozen (for instance when they are on trial).

[MrHug]

I've included a clause to deal with @jdonkervliet's valid comment.

[jdonkervliet]

Looks reasonable now.

[jdonkervliet]

:+1:

[pimotte]

If a rules prohibits opening an issue, then this enables you to open an issue. Is this by design?

[MrHug]

Hmm no it wasn't and it could be a problem with Trial participants going on Hiatus. Fixing now.

[MrHug]

Well looks like I have somehow screwed over the git history of this branch... Somehow I have managed to get @ManInTheGitHub's PR in here and it shows up as a difference to master for some reason?

[MrHug]

Ok merging master back in fixed things...

Anway @jdonkervliet your vote is now invalid ;)

[ManInTheGitHub]

Given that I'm still quite likely to do things incorrectly here, this looks fine by me :)

[ManInTheGitHub]

:+1:

[pimotte]

If opening an issue is prohibited, a player could be put on trial for opening a pull request that does not adhere to all the rules.

[MrHug]

Fixed, @ManInTheGitHub your vote is now invalid again ;(

[pimotte]

:+1:

[jdonkervliet]

:+1:

[MrHug]

With 3/4 votes, this can be merged.