search

pimotte / nomic

6 stars 5 forks source link

353: Point refactoring #84

Closed pimotte closed 8 years ago

pimotte commented 8 years ago

今日、両親の自動車を運転しました。= Today, I drove my parents car.

This PR is dependent on #83

MrHug commented 8 years ago

Looks good, but I want the fixes in #83 first... Voting in favour of this however, means voting in favour of #83. Thus let me do it like this

MrHug commented 8 years ago

IF I vote in favour of #83 THEN :+1:

pimotte commented 8 years ago

I'm pretty sure you just violated the Dependency Inversion Principle ;)

MrHug commented 8 years ago

Well yeah, but meh :P

pimotte commented 8 years ago

As per 349, I'm issuing a warning.

pimotte commented 8 years ago

The typo's that @jdonkervliet mentioned where already fixed in the parent PR, but I rebased to reflect this. This means all votes here are invalid.

MrHug commented 8 years ago

:+1:

MrHug commented 8 years ago

I just spotted an oversight. A warning is not reset after a change...

Thus the following is possible;

Make a PR, immediate issue warning. Change PR changes to "Rule x: I get 100000 points" when 71 hours 59 minutes have passed 1/1 votes are in favour (no matter what, because all other votes are voided and the warning is not reset) Rule gets merged

Perhaps we should fix that...

pimotte commented 8 years ago

It would be nice to make that explicit, but I would hold that an action of such form would still violate 106.

pimotte commented 8 years ago

Since warnings are not currently reset, I'm going to say this is 2/2 and merge it.