search

pimp-my-book / umqombothi-component-library

PMB Plus - React Component Library 🍶
https://umqombothi.netlify.com
2 stars 2 forks source link

update package.json - update bit's config #31

Closed GiladShoham closed 5 years ago

GiladShoham commented 5 years ago

This commit contain 2 different changes:

  1. remove the unnecessary bit's config. the override configs as they were doesn't apply on any component so they were redundant.
  2. move the react and react-dom to be peer dependencies. it's better when implementing a component library to set them as a peer. It's also important for the bit's component. (it can be done using the bit's override config as well, but better that way).
AmoDinho commented 5 years ago

Hi @GiladShoham, Thanks for introducing these changes! 👍