search

pimterry / lambda-git

A git binary installed through NPM, for use with AWS Lambda
MIT License
78 stars 13 forks source link

installGit should return a Promise to avoid racing conditions #2

Closed maikokuppe closed 7 years ago

maikokuppe commented 7 years ago

Tests for Node 0.10 and 0.12 are failing because they don't support promises natively. May I suggest to remove the tests for node 0.10 and 0.12?

pimterry commented 7 years ago

Hi @maikokuppe, this looks great! Nice work. Yes, I'm very happy to upgrade in line with Node LTS, so testing on 4+ would be great. If you make that change and get the tests passing, I'm happy to merge.

As an aside, I don't really use this library myself any more, so it's become basically unmaintained. If you're actively using it, you're probably closer to this than I am - would you be interested in becoming a maintainer? Tiny library, so shouldn't be much work, but that'd let you make changes like this for yourself in future.

maikokuppe commented 7 years ago

Yes, becoming a maintainer sounds good :) I should mention that I'm probably going to use this library as it is, so I'm probably going to choose the next motivated developer to maintain it if he or she comes around ;)

pimterry commented 7 years ago

Merged! I've given you push access to the repo too. Let me know your npm username and I'll add you as a collaborator there as well so you can publish.

maikokuppe commented 7 years ago

My npm username is maiko

pimterry commented 7 years ago

@maikokuppe great, thanks! I've given you publish permissions.

pimterry commented 7 years ago

(I think, let me know if you have any trouble)