search

pimterry / loglevel

:ledger: Minimal lightweight logging for JavaScript, adding reliable log level methods to wrap any available console.log methods
MIT License
2.6k stars 158 forks source link

Jasmine:requirejs test is hanging #133

Open ossdev07 opened 5 years ago

ossdev07 commented 5 years ago

Hello Team,

The grunt-contrib-jasmine and grunt-contrib-qunit used as a development dependency of the package are currently supporting phantomjs as a browser testing environment and phantomjs is an unmaintained project so it will be good to replace it with some maintained alternatives like chrome headless.

Updating the grunt-contrib-qunit and grunt-contrib-jasmine version to latest will provide support for chrome headless for the package and it is good to use the updated dependencies in the package.

I was checking the package on my local environment with these changes, facing an issue in running jasmine: requirejs test case as it is not proceeding further with chrome headless. To test all the test cases with chromeHeadless browser I have commented the (jasmine:requirejs) test case, as a result, I could see all the other jasmine test case are passing successfully.

In my view, the issue is with jasmine:requirejs test case only I will be glad if you could share any input regarding this.

pimterry commented 5 years ago

Hmm, not sure really! I would be interested in moving to Chrome headless, you're totally right, that'd be a valuable update over phantomjs.

Do the requirejs tests all pass locally for you before your changes? If you run it in Chrome non-headless, are there any interesting errors there?

I'm happy to try and give you some debugging pointers, but I'm afraid I don't have time to implement this myself any time soon. I'd definitely be interested in taking a look at a PR if you do get it working though :+1:

ossdev07 commented 5 years ago

@pimterry Thanks for the quick reply

The requirejs tests are all failing on my local system as well, but I am checking it with headless chrome only because the grunt-contrib-qunit and grunt-contrib-jasmine directly provide support for headless chrome with there latest versions.

It will be great if you could provide any debugging pointers, I will work through it.

Please have a look at some of my queries: -> How does SpecRunner.html file gets created and used? -> The only difference I could find between chrome and phantomjs is that at runtime with phantomjs inside grunt module the requirejs and jasmine-helper.js files are being created but for chrome, they are not present ( requirejs file is also being created with chrome but not at the similar location as of phantomjs)

I appreciate your help and time for this!

Mr0grog commented 7 months ago

@ossdev07 I don’t know if this is still an issue for you, but it should have been fixed by some of the cleanup/modernization work I did in #190, #192, #194, and #195.