search

pimterry / notes

:pencil: Simple delightful note taking, with more unix and less lock-in.
https://github.com/pimterry/notes
MIT License
1.26k stars 82 forks source link

Add combined grep/find as search #16

Closed khamer closed 7 years ago

khamer commented 7 years ago

Here's a rough implementation of a combining grep/find together, so that you can search for files based on filename or contents. Performance might be better if we ran the grep and find separately and then sorted/uniq'd the results together, but this solution works.

I did run the tests and threw together a new test-search.bats based on the others. I called this functionality 'search' as I wasn't sure whether you wanted this to replace existing functionality or not.

khamer commented 7 years ago

README updated and rebased PR into a single commit.

pimterry commented 7 years ago

README looks good, but the build's now broken - looks like there's a syntax error somewhere.

khamer commented 7 years ago

Just pushed some changes that should getting it passing the tests; sorry about that.

pimterry commented 7 years ago

Looks good, thanks! Merged.