search

pimterry / notes

:pencil: Simple delightful note taking, with more unix and less lock-in.
https://github.com/pimterry/notes
MIT License
1.26k stars 82 forks source link

bash completion support #5

Closed ecksun closed 7 years ago

ecksun commented 7 years ago

Simple bash completion support

pimterry commented 7 years ago

It's awesome to see people like you diving in on substantial improvements like this, this is great.

I've added a couple of comments. This also now needs rebasing, I think just because some of the README has changed in the meantime because of conflicts. Happy to merge once that's all done.

Thanks!

ecksun commented 7 years ago

Now we have some tests, are handling whitespace notes and ignores hidden files.

Since I rebased the branch it seems I can no longer look at your review comments, nor mark tyour requested changes as completed (if that is something you can do with github).

jacobmischka commented 7 years ago

@pimterry you can rebase when accepting the PR, there's a dropdown. https://help.github.com/articles/about-pull-request-merges/

pimterry commented 7 years ago

@jacobmischka You can, but that's for a different use case, when you don't want a merge commit, and the PR doesn't currently have conflicts. You can't use that to avoid the rebasing required to fix conflicts in a PR (and I'd quite like to keep the merge commits, just for consistency).

@ecksun I think this looks good now. I need to do a proper test and review, and I don't have time today, but I should on Monday I think, so I'll take a proper look then, and merge it in. Great work, thanks!

pimterry commented 7 years ago

Looks good, all works nicely for me locally, merged. Thanks @ecksun!