pimterry / notes

:pencil: Simple delightful note taking, with more unix and less lock-in.

https://github.com/pimterry/notes

MIT License

1.24k stars 82 forks source link

Closed rmNULL closed 6 years ago

rmNULL commented 6 years ago

Fixes

Fixes #53 Closes #53

[x] I have made a change to this repository, be it functionality, testing, documentation, spelling, or grammar.
[x] I updated my branch with the master branch.
[x] I have commented any code I have modified or I did not modify any code
[ ] I have added necessary documentation about the functionality in an appropriate .md file
[ ] I have added the necessary testing to prove my fix is effective or my feature work, or I did not modify functionality.

Does not append extension to the notename if it already has an extension.

rmNULL commented 6 years ago

Little more exploration of the program revealed that extra extension .md problem was caused by new_note() calling open_note() with extension.

That shouldn't be happening because open_note() will add ext(through get_full_note_path()) if the filename doesn't end with $NOTES_EXT

P.S: sorry for being verbose

pimterry commented 6 years ago

Good find! That totally makes sense, thanks for fixing it :+1: