pimterry / notes

:pencil: Simple delightful note taking, with more unix and less lock-in.
https://github.com/pimterry/notes
MIT License
1.24k stars 82 forks source link

exit 1 on failure to create NOTES_DIRECTORY #56

Closed rmNULL closed 6 years ago

rmNULL commented 6 years ago

Fixes

Fixes #55 Closes #55

Checklist

Short description of what this PR does:

primis commented 6 years ago

It looks great, but I might suggest adding a "please" to the change to sound nicer. Or an explanation like "Could not create the notes directory, please change..." for verbosity sake.

rmNULL commented 6 years ago

okay, sure.

pimterry commented 6 years ago

I've added a couple of bonus tweaks to this (and tests), but overall it looks great to me! Merging now.

rmNULL commented 6 years ago

Lol nice. "Could not create directory " will be redundant output as mkdir outputs a similar message. Maybe we should redirect mkdir to /dev/null