pimterry / notes

:pencil: Simple delightful note taking, with more unix and less lock-in.

https://github.com/pimterry/notes

MIT License

1.26k stars 82 forks source link

Open rmNULL opened 6 years ago

rmNULL commented 6 years ago

Fixes

Fixes #58 #57 Closes #58 #57

[x] I have made a change to this repository, be it functionality, testing, documentation, spelling, or grammar.
[x] I updated my branch with the master branch.
[ ] I have added the necessary testing to prove my fix is effective/my feature works (or I did not modify functionality).
[ ] I have added necessary documentation about the functionality in an appropriate .md file.
[ ] I have appropriately commented any code I have modified

primis commented 6 years ago

Have you added tests to address the fix?

rmNULL commented 6 years ago

@primis nope, I have problem running bats on my system.

eshapard commented 3 years ago

I noticed this option and that the open command is problematic last night.

I think it might be easier to set a config file variable with a default value that the user can override.

Maybe: FILE_MAN=open and then open the directory with: $FILE_MAN $notes_directory

Add some documentation and let the user decide what kind of command-line or gui file manager he wants to use for this.