pimterry / notes

:pencil: Simple delightful note taking, with more unix and less lock-in.

https://github.com/pimterry/notes

MIT License

1.24k stars 82 forks source link

fix autocompletion for short commands #71

Closed ingkebil closed 5 years ago

ingkebil commented 5 years ago

Fixes #38

Checklist

[x] I have made a change to this repository, be it functionality, testing, documentation, spelling, or grammar.
[x] I updated my branch with the master branch.
[ ] I have added the necessary testing to prove my fix is effective/my feature works (or I did not modify functionality).
[ ] I have added necessary documentation about the functionality in an appropriate .md file.
[ ] I have appropriately commented any code I have modified

Short description of what this PR does:

The short commands do not autocomplete file names. e.g. notes o <tab><tab> does not yield the files in your $NOTES_DIRECTORY. This PR adds that autocompletion.
The search and ls commands were omitted from the autocomplete. This has been added and is covered by the unit tests.

I wasn't sure if this needs extra unit tests. Let me know what you think!

pimterry commented 5 years ago

Nice work! This looks great to me, merging now. Thanks for contributing :+1: