Ensure consistent order of find/grep/search results

pimterry / notes

:pencil: Simple delightful note taking, with more unix and less lock-in.

https://github.com/pimterry/notes

MIT License

1.24k stars 82 forks source link

Ensure consistent order of find/grep/search results #73

Closed pimterry closed 4 years ago

pimterry commented 4 years ago

Fixes #72

Based on your comment @primis, I think this is simply non-deterministic: on my machine it seems to fail when running the commands manually or through the test suite, even though it used to work.

I propose we start just explicitly sorting results, which makes this test pass (on Travis & my machine at least, and in theory everywhere), and seems like a nice & sensible thing to do anyway. What do you think?

primis commented 4 years ago

Seems good, I'm gonna merge it

pimterry commented 4 years ago

:+1: :+1: :+1: