pimterry / notes

:pencil: Simple delightful note taking, with more unix and less lock-in.

https://github.com/pimterry/notes

MIT License

1.24k stars 82 forks source link

completion add mv #88

Closed lasorda closed 2 years ago

lasorda commented 2 years ago

Fixes

Checklist

[x] I have made a change to this repository, be it functionality, testing, documentation, spelling, or grammar.
[x] I updated my branch with the master branch.
[x] I have added the necessary testing to prove my fix is effective/my feature works (or I did not modify functionality).
[x] I have added necessary documentation about the functionality in an appropriate .md file.
[x] I have appropriately commented any code I have modified

Short description of what this PR does:

add mv completion to _notes

pimterry commented 2 years ago

Nice, thanks!

I'm happy to merge this as-is for the quick improvement, but is there any chance you want to look at the argument completion too? In _notes () { ... } below. If you add mv in there too, we should be able to add proper bash completion for note names and directories, as with ls, rm, etc.

pimterry commented 2 years ago

@lasorda fair enough, you're welcome to close this of course, but just so it's clear: I am happy to merge this as it is (or, as it was) if that's best for you. Alternatively you're welcome to add argument completion for mv as well, since that might be useful too, but it's up to you, that's not strictly required.

If you do want to merge this as-is or if you want some help extending it, just let me know :smile: