pimterry / notes

:pencil: Simple delightful note taking, with more unix and less lock-in.
https://github.com/pimterry/notes
MIT License
1.24k stars 82 forks source link

New command: `realpath` #94

Closed cybercoder-naj closed 6 months ago

cybercoder-naj commented 6 months ago

Resolves #93

Closes #92

Checklist

Short description of what this PR does:

cybercoder-naj commented 6 months ago

I have an issue by running a particular test case. If you have have a look at my test case here, it runs indefinitely. Funny enough, a Ctrl+C (SIGINT) does not stop the test case; force quitting the terminal is the only option. However, the other test cases work. Can someone please guide why this error occurs and how to fix it?

cybercoder-naj commented 6 months ago

I have an issue by running a particular test case. If you have have a look at my test case here, it runs indefinitely.

You're not overriding EDITOR anywhere in the test case, so the notes new in that test is actually opening up your real editor somewhere, and blocking while until that exits.

You can use something like export EDITOR=touch to skip that, as in some of the other similar tests.

I think that's the only changed required here though, otherwise this all looks good to me! Very clean. If you patch that up and check it works, I'll merge this 👍

Thanks for your help. The test cases pass successfully now.

pimterry commented 6 months ago

Perfect, thanks! :+1: