search

pimusicbox / mopidy-musicbox-webclient

Web Client for Mopidy Music Server and the Pi MusicBox
https://www.pimusicbox.com
Apache License 2.0
398 stars 106 forks source link

iFrame or embed the settings page instead of leaving musicbox #72

Open EHLOVader opened 9 years ago

EHLOVader commented 9 years ago

I may be disabling the settings and power buttons to prevent anyone from accidentally rebooting the server.

But would it be possible or helpful even to embed the settings frontend into the MusicBox interface so it would be easier to return using the sidebar?

kingosticks commented 9 years ago

Yep I agree it would be a bit slicker. But it should be done in such a way that mopidy-websettings still works and looks decent when used without musicbox-Webclient. Although I don't know if many people make use of it as a standalone extension, it's nice it's flexible like this. On 27 Feb 2015 00:06, "Joseph Richardson" notifications@github.com wrote:

I may be disabling the settings and power buttons to prevent anyone from accidentally rebooting the server.

But would it be possible or helpful even to embed the settings frontend into the MusicBox interface so it would be easier to return using the sidebar?

— Reply to this email directly or view it on GitHub https://github.com/woutervanwijk/Mopidy-MusicBox-Webclient/issues/72.

kingosticks commented 8 years ago

I had a quick play with this a while ago and it needs a bit of fiddling, particularly with the different style sheets being used. Using the same/compatible styles would be the first step. I found just embedding the settings HTML into a div (like how the other sections work) to be easier than integrating an iframe. But both options are valid.