search

pimutils / khal

:calendar: CLI calendar application
https://lostpackets.de/khal/
MIT License
2.6k stars 199 forks source link

Implementation for issue #809 and general display improvements #1212

Closed GabrielDum closed 5 months ago

GabrielDum commented 1 year ago

We used an awful lot of try/excepts in this PR, so if you have a better way of doing it you're welcome ! Anyway this PR might not be perfect but proposes a new display for both khal and ikhal where months are visually separated. The ideas in came from @aleprovencio and @WhyNotHugo. I did it with a coworker, so i added him as well to the AUTHORS file. There might be some useless commits, just look at the final files. We won't be working on it anymore, so if it isn't receivable but you like the idea, feel free to adapt and improve it !

w-jablonski commented 1 year ago

months are visually separated

Please! Can we consider this?

geier commented 11 months ago

Thanks for your PR, and sorry for not taking a look at this earlier.

Personally, I'm not a fan of visual separation between different months (the first khal script I wrote because I didn't like the output of cal or ncal). If you make this configurable and not the default behavior, I'm not against merging it though.

geier commented 11 months ago

Apart from that, there seem to be some problem with the current state:

image image image
geier commented 11 months ago

Perhaps we can also find a way to make the separation work as a plugin first and let it mature outside of the main code base.

geier commented 5 months ago

closed for now, please re-open if you are still interested in working on this.