search

pimutils / khal

:calendar: CLI calendar application
https://lostpackets.de/khal/
MIT License
2.54k stars 198 forks source link

ikhal: fix deleting of multiple instances #1273

Closed geier closed 1 year ago

geier commented 1 year ago

When deleting multiple instances of the same recurring event, ikhal would crash because of mismatching etags. This would happen, because we delete one instance after the next, each time updating the etag. As we check for matching etags when deleting (the one in the database and the one stored in ikhal), this would crash ikhal. Matching the etag makes sense, as we might overwrite freshly synced data otherwise. For now, the server wins.

fix #1190

geier commented 1 year ago

thanks for reviewing @WhyNotHugo! I'll wait a few more days and see if someone is able to give this a try.

tobiolo commented 1 year ago

I tested it. It works without problem. Thanks for having it fixed. vdirsyncer outputs a warning warning: Deleting an item with no etag. when it gets synced but I think this is ok.

WhyNotHugo commented 1 year ago

vdirsyncer outputs a warning warning: Deleting an item with no etag. when it gets synced but I think this is ok.

This sounds unrelated. Doesn't it also print the same thing when deleting a non-recurring event?