search

pimutils / khal

:calendar: CLI calendar application
https://lostpackets.de/khal/
MIT License
2.54k stars 198 forks source link

[pre-commit.ci] pre-commit autoupdate #1292

Closed pre-commit-ci[bot] closed 8 months ago

pre-commit-ci[bot] commented 11 months ago

updates:

WhyNotHugo commented 8 months ago

(I tend to only merge these when they actually include fixes. Otherwise weekly updates add too much noise to git history)

geier commented 8 months ago

@WhyNotHugo agreed, but this one found at least the type() issues. Not so sure about the issue in setup.py. The options I see are removing the if sys.version() part completely or adding a # noqa behind.

WhyNotHugo commented 8 months ago

A # noqa: UP036 sounds good. This check honestly bothers me a bit; this code is perfectly valid, even if this version of Python is unsupported.

Switching to pyproject.toml entirely would negate the issue completely.