pimutils / khal

:calendar: CLI calendar application
https://lostpackets.de/khal/
MIT License
2.54k stars 198 forks source link

support for color theme plugins #1303

Closed geier closed 3 months ago

geier commented 8 months ago

With this PR we support plugins that provide color themes.

A first example plugin implementing a gruvbox plugin can be found here: here https://github.com/geier/khal_gruvbox image

mb720 commented 2 months ago

Since this is closed now, is there another issue that people interested in color theme support can track?

geier commented 2 months ago

Not really, with https://github.com/pimutils/khal/pull/1312 color theme plugins should work.

Are you looking for something specific?

mb720 commented 2 months ago

I'm really interested in configuring colors via a different config file than /usr/lib/python3.12/site-packages/khal/ui/colors.py since that gets overwritten on updates (I'm on Arch). I'm currently using khal version 0.11.3 and tried yesterday to get the new color theme plugin to work:

  1. I copied __init__.py to ~/.local/share/khal/plugins, that's my XDG_DATA_HOME.

  2. I changed ~/.config/khal/config to use it:

    [view] theme = gruvbox

  3. But I got this error:

    critical: config error: critical: in [view] theme: the value "gruvbox" is unacceptable.

Maybe I overlooked something or my version of khal on Arch doesn't support the plugins yet.

Thanks for your help and generally your work on khal!

geier commented 2 months ago

Sorry, I forgot to merge the importlib branch (I have done that now).

You will need to install that package, the README has a pointer. Open an issues here or at khal_gruvbox if you have any issues.