pimutils / khal

:calendar: CLI calendar application
https://lostpackets.de/khal/
MIT License
2.62k stars 207 forks source link

Split calendar and event editor #179

Closed WhyNotHugo closed 8 years ago

WhyNotHugo commented 9 years ago

Hi,

This is more of a "discussion" ticket than an actual issue/feature request. I'd actually even like to work on this myself if I know this'll be accepted as a PR.

Currently khal is two things:

  1. A calendar/agenda.
  2. An events editor (or a vcf editor, if you will).

I'm interested in spliting these things in two different binaries (keeping them them same for now, UI-wise, and likely reusing all existing code), and have calendar.bin invoke the event-editor.bin when the user wants to edit/create an event.

From the end-user PoV, this would be almost the same, with one main difference which is what I'm aiming at: which calendar editor program to use should be configurable. My long-term interest is to write a different one (though vim would be an acceptable alternative, for example), and configure khal to use that, so when the user edits an event, that program can be called instead.
This more closely follows the unix-philosophy of "do one thing and do it well" (kinda like a file browser vs file editor if you will), but also makes room for various external vcf-editors.

Mostly my aim with this issue here is to ask:

Thanks.

WhyNotHugo commented 9 years ago

Huh, looks like this would also cover #31.

untitaker commented 9 years ago

I think that's a great idea, however, I'm not sure how to implement the calendar selector that's currently part of the editor.

WhyNotHugo commented 9 years ago

I forgot about that, and now I recall that I had that same though last night before I fell asleep, hah.

Probably an intermediate step when creating the event, with the following flows:

For creations:

  1. Open ikhal.
  2. Select a date.
  3. Press n.
  4. A calendar selection menu appears.
  5. The event-editor is summoned.

For editing events, simply set a new hotkey for calendar selection (c?). It would show the same screen as the one shown when selecting a calendar for a new event.

This would actually alter the flow of event creation/modification, contrary to the my inital statement.

I'd leave the calendar selection out of the event-editor, since it should only be concerned with editing a vcf file, and calendar selection is more about where to save that file instead.

geier commented 9 years ago

I'm all for that "do one thing only, but do it well". But when creating or more importantly when editing an event I'd really like to see other events scheduled for that day(s). ikhal doesn't do that well at the moment either, but I think it will be more difficult with creating two different tools.

As a compromise I would like to suggest the following:

geier commented 8 years ago

I'll close this in favor of #31