search

pimutils / mates.rs

A very simple commandline addressbook
MIT License
63 stars 9 forks source link

fish completion causes error #22

Closed j605 closed 6 years ago

j605 commented 6 years ago

This is the output you get in fish,

mates h<W> fish: An error occurred while redirecting file “email”
open: No such file or directory

I think this is caused by wrong quoting in line 19 of that file.

diff --git a/usr/share/fish/completions/mates.fish b/tmp/mates.fish
index db039a9..f2fa4c1 100644
--- a/usr/share/fish/completions/mates.fish
+++ b/tmp/mates.fish
@@ -16,7 +16,7 @@ complete -c mates -n "__fish_using_command mates" -s V -l version -d "Prints ver
 complete -c mates -n "__fish_using_command mates" -f -a "index" -d "Rewrite/create the index"
 complete -c mates -n "__fish_using_command mates" -f -a "mutt-query" -d "Search for contact, output is usable for mutt's query_command."
 complete -c mates -n "__fish_using_command mates" -f -a "file-query" -d "Search for contact, return just the filename."
-complete -c mates -n "__fish_using_command mates" -f -a "email-query" -d "Search for contact, return "name <email>"."
+complete -c mates -n "__fish_using_command mates" -f -a "email-query" -d "Search for contact, return name <email>."
 complete -c mates -n "__fish_using_command mates" -f -a "add" -d "Take mail from stdin, add sender to contacts. Print filename."
 complete -c mates -n "__fish_using_command mates" -f -a "edit" -d "Open contact (given by filepath or search-string) interactively."
 complete -c mates -n "__fish_using_command mates" -f -a "help" -d "Prints this message or the help of the given subcommand(s)"
gnuish commented 6 years ago

The completion file is generated by clap. It seems like it was a bug that was fixed in the latest versions of clap (fixed in 2.26.1), and now it properly quotes it.

j605 commented 6 years ago

Will you be updating the version in Cargo.toml? I can update it locally as well. Thanks, I will close the issue.

untitaker commented 6 years ago

nice find, please send a PR for updating the version.

Never builds will not automatically have the new version since we pin the version in Cargo.lock

On Fri, May 11, 2018 at 07:41:42AM -0700, Jagannathan Tiruvallur Eachambadi wrote:

Will you be updating the version in Cargo.toml? I can update it locally as well. Thanks, I will close the issue.

-- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/pimutils/mates.rs/issues/22#issuecomment-388384256