When we read in binary mode, write using it as well, fixes writing under Windows

pimutils / todoman

✅ A simple, standards-based, cli todo (aka: task) manager.

https://todoman.readthedocs.io

ISC License

489 stars 78 forks source link

When we read in binary mode, write using it as well, fixes writing under Windows #468

Closed tyrylu closed 2 years ago

tyrylu commented 2 years ago

Under Windows, the distinction between binary or text mode actually exists, this PR allows to run the creation commands under Windows.

WhyNotHugo commented 2 years ago

This makes sense; it also avoids a decode+encode cycle that's not necessary.

I guess files still end up UTF-8 encoded, right?

WhyNotHugo commented 2 years ago

Thanks!

tyrylu commented 2 years ago

They should, but it depends on the implementation in vobject. However, the decode was depending on that behavior as well, even if in a slightly different way, so, yes, the files will end up as UTF-8.

2. 12. 2021 v 12:10, Hugo Osvaldo Barrera @.***>:

Thanks!

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe. Triage notifications on the go with GitHub Mobile for iOS or Android.