search

pimutils / todoman

✅ A simple, standards-based, cli todo (aka: task) manager.
https://todoman.readthedocs.io
ISC License
482 stars 76 forks source link

Implement undo #520

Closed r4ulill0 closed 7 months ago

r4ulill0 commented 1 year ago

The undo functionality does not really resolve recurring todos because that functionality is not implemented yet so there is a test that will fail until that is implemented (I'm planing to solve that myself, but one thing at a time).

@WhyNotHugo tell me if you see something off and sorry for taking that long, recurring todos distracted me a bit :laughing:

WhyNotHugo commented 1 year ago

I don't fully understand why one tests is failing: https://builds.sr.ht/~whynothugo/job/981248#task-test-262

r4ulill0 commented 1 year ago

I don't fully understand why one tests is failing: https://builds.sr.ht/~whynothugo/job/981248#task-test-262

Recurring test doesn't work because there are some recursion fields that are not persisted yet. We have to deal with some issues #485 in order for it to work. I'm planning on taking all of them but one step at a time.

I tried to implement persistence for RELATED-TO but it was a pretty big change and it has its own issue #288. You can open a new issue to fix this test and add it to #485 if you want. Also we can delete the test until its relevant. I'm fine with either option.

r4ulill0 commented 1 year ago

I have marked "not implemented" the test as the RELATED-TO property needs to be persisted before it can work.

Now arch build passes (Alpine build just exploded and I don't understand why).

hrueschwein commented 11 months ago

Is there any progress?..

r4ulill0 commented 11 months ago

Is there any progress?..

It should be ready to merge. I don't know if @WhyNotHugo has any more things to check.