Open dvzrv opened 1 year ago
Looking at the patches applied on arch with git log release-2.1.2..3c21a429d7275aa79069c7a331fdb3de9138d2b2 -p
, I suspect that this commit introduces the issue.
commit d1710f0983e86dc5ec06efec6e94f3b6d204bbb3
Author: Alexey Stepanov <penguinolog@users.noreply.github.com>
Date: Tue Apr 18 17:35:19 2023 +0200
[BREAKING CHANGE] Refactoring: Split event loop in several modules (#537)
* [BREAKING CHANGE] Refactoring: Split event loop in several modules
* `urwid.main_loop` is split into multiple modules which is easier to maintain
* `urwid.compat` is not used anymore and removed
* `TornadoEventLoop`, `GLibEventLoop`, `TwistedEventLoop` and `TrioEventLoop`
accessible ONLY if required dependencies installed
(like: Tornado installed -> `TornadoEventLoop` is accessible for import)
* `TornadoEventLoop` use the same idle logic as `AsyncioLoop`:
tornado.ioloop.IOLoop is asyncio based.
* Trio < 0.15 is not supported. Version 0.15 was released almost 3 years ago.
* Tornado < 5.0 is not supported. Tornado 5.0 was released 5 years ago.
* Remove useless shebang
* `EventLoop` should be real abstract
* add new module docstrings
* Fix docstrings
* remove unneeded import
---------
Co-authored-by: Aleksei Stepanov <alekseis@nvidia.com>
I'm not sure what to do here. Is urwid-upstream planning a new release with breaking changes to fix the CVEs?
I think they are working on things actively atm, but it appears they are also introducing some breakage (sometimes accidentally).
I'll disable the test for now.
Leaving the test disabled for now sounds good to me.
I don't think that I'll address this until upstream provides a new release (given that it's a moving target and it's unclear if it will contain breaking changes or not).
Looks like this only affects the tests anyway.
Hi! While trying to package 4.3.0 for Arch Linux I ran into test failures due to urwid:
Due to CVEs in ncurses I had to upgrade urwid to a commit past its last release: https://gitlab.archlinux.org/archlinux/packaging/packages/python-urwid/-/commits/main
Full build/test logs: todoman-4.3.0-1-x86_64-build.log todoman-4.3.0-1-x86_64-check.log